This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author terry.reedy
Recipients terry.reedy
Date 2013-07-13.06:10:19
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1373695819.6.0.661777672646.issue18439@psf.upfronthosting.co.za>
In-reply-to
Content
My current list of changed_files() (command from the code)
% hg status --added --modified --no-status
Lib\idlelib\RstripExtension.py
Misc\ACKS
Misc\NEWS
Lib\idlelib\idle_test\mock_idle.py
Lib\idlelib\idle_test\test_rstrip.py

but
F:\Python\dev\py33>pcbuild\python_d tools/scripts/patchcheck.py
...
Misc/ACKS updated ... NO
Misc/NEWS updated ... NO

The problem is that 'Misc/ACKs' is not in the list, even though 'Misc\ACKS' is ;-(.

One possible fix is to conditionally change '\' to '/' in the file list, or maybe just in special_files, as that seems to be the only category affected.

Another is to change line 156 (3.3) from
    special_files = {'Misc/ACKS', 'Misc/NEWS'} & set(file_paths)
to
    special_files = {'Misc/ACKS', 'Misc/NEWS', 'Misc\ACKS', Misc\NEWS'} & set(file_paths).

A third is to check for both versions in credit_given() (125) and reported_news() (131).

I don't know if there is an issue with Macs or not.
History
Date User Action Args
2013-07-13 06:10:19terry.reedysetrecipients: + terry.reedy
2013-07-13 06:10:19terry.reedysetmessageid: <1373695819.6.0.661777672646.issue18439@psf.upfronthosting.co.za>
2013-07-13 06:10:19terry.reedylinkissue18439 messages
2013-07-13 06:10:19terry.reedycreate