➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author vstinner
Recipients Devin Jeanpierre, mark.dickinson, serhiy.storchaka, skrah, vstinner
Date 2013-07-01.23:56:42
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1372723003.78.0.256567073595.issue17870@psf.upfronthosting.co.za>
In-reply-to
Content 
Updated patch (version 3), addressing last issues of Mark's review:

- add a simple unit test in _testcapi: check that PyLong_AsIntMax_t(INTMAX_INT - 1), PyLong_AsIntMax_t(INTMAX_MAX + 1) and PyLong_AsUintMax_t(UINTMAX_MAX + 1) fail with OverflowError
- rely on stdint.h on Windows, with a fallback on __int64 for Visual Studio 2008
- PyLong_AsIntMax_t() and PyLong_AsUintMax_t() compute directly the result (rather than calling _PyLong_AsByteArray)

I give you one or two days for a last review, and then I'm going to commit the new functions.
History
Date User Action Args
2013-07-01 23:56:44vstinnersetrecipients: + vstinner, mark.dickinson, Devin Jeanpierre, skrah, serhiy.storchaka
2013-07-01 23:56:43vstinnersetmessageid: <1372723003.78.0.256567073595.issue17870@psf.upfronthosting.co.za>
2013-07-01 23:56:43vstinnerlinkissue17870 messages
2013-07-01 23:56:43vstinnercreate