Message192130
Sorry that I was late with review. Here is some nitpicks from me.
Using assertRaises() as context manager in this case looks cleaner to me:
with self.assertRaises(ValueError):
unpickler.memo = {-1: None}
Moving the `if (idx == -1 && PyErr_Occurred())` check inside the `if (idx < 0)` block will increase the perfomance a little. |
|
Date |
User |
Action |
Args |
2013-07-01 14:20:18 | serhiy.storchaka | set | recipients:
+ serhiy.storchaka, christian.heimes, python-dev |
2013-07-01 14:20:18 | serhiy.storchaka | set | messageid: <1372688418.39.0.708112233626.issue18339@psf.upfronthosting.co.za> |
2013-07-01 14:20:18 | serhiy.storchaka | link | issue18339 messages |
2013-07-01 14:20:18 | serhiy.storchaka | create | |
|