This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author serhiy.storchaka
Recipients christian.heimes, python-dev, serhiy.storchaka
Date 2013-07-01.14:20:18
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1372688418.39.0.708112233626.issue18339@psf.upfronthosting.co.za>
In-reply-to
Content
Sorry that I was late with review. Here is some nitpicks from me.

Using assertRaises() as context manager in this case looks cleaner to me:

    with self.assertRaises(ValueError):
        unpickler.memo = {-1: None}

Moving the `if (idx == -1 && PyErr_Occurred())` check inside the `if (idx < 0)` block will increase the perfomance a little.
History
Date User Action Args
2013-07-01 14:20:18serhiy.storchakasetrecipients: + serhiy.storchaka, christian.heimes, python-dev
2013-07-01 14:20:18serhiy.storchakasetmessageid: <1372688418.39.0.708112233626.issue18339@psf.upfronthosting.co.za>
2013-07-01 14:20:18serhiy.storchakalinkissue18339 messages
2013-07-01 14:20:18serhiy.storchakacreate