Author kristjan.jonsson
Recipients asvetlov, brandon-rhodes, christian.heimes, giampaolo.rodola, jcea, kristjan.jonsson, pitrou
Date 2013-06-27.23:15:28
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1372374929.06.0.229576608394.issue16487@psf.upfronthosting.co.za>
In-reply-to
Content
Okay, I have updated the patch as suggested.
string mode means PEM encoding, binary mode DER encoding.
Note that DER encoding is more limited, there is no way to concatentate private keys and certificates into one file (the PEM decoder searches the file until it finds the proper data it is looking for, certificate or private key).

Also, the unittests don't test for DER encoded private key, because there is no way to generate them currently.  The conversion functions in ssl only cope with certificates.  Although adding them, changing them would be trivial.  These functions should also probably know how to split a PEM file into sections so that they can be individually converted.
History
Date User Action Args
2013-06-27 23:15:29kristjan.jonssonsetrecipients: + kristjan.jonsson, jcea, pitrou, giampaolo.rodola, christian.heimes, asvetlov, brandon-rhodes
2013-06-27 23:15:29kristjan.jonssonsetmessageid: <1372374929.06.0.229576608394.issue16487@psf.upfronthosting.co.za>
2013-06-27 23:15:29kristjan.jonssonlinkissue16487 messages
2013-06-27 23:15:28kristjan.jonssoncreate