Author christian.heimes
Recipients asvetlov, brandon-rhodes, christian.heimes, giampaolo.rodola, jcea, kristjan.jonsson, pitrou
Date 2013-06-27.00:48:01
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1372294082.65.0.0208382829343.issue16487@psf.upfronthosting.co.za>
In-reply-to
Content
Thx Kristj√°n!

My patch maps PyUnicode to PEM encoded cert data and objects with Py_Buffer support to DER encoded cert data. Perhaps you like to you the same concept in your patch to support TextIO and BytesIO read() methods. Feel free to reuse as much of my patch as you like.

You don't check ERR_GET_LIB() in some places.

Could you please add a comment about extra_chain_cert in PySSL_CTX_use_certificate_chain_mem() and SSL_CTX_get_cert_store() in PySSL_CTX_load_verify_certs_mem()? The difference between the extra chain and the trusted store got me confused more than once. As far as I recall the trusted store is suppose to contain only trusted root CA. The extra chain is uesd to provide intermediate certs for the cert chain between a root CA and the service's cert.
History
Date User Action Args
2013-06-27 00:48:02christian.heimessetrecipients: + christian.heimes, jcea, pitrou, kristjan.jonsson, giampaolo.rodola, asvetlov, brandon-rhodes
2013-06-27 00:48:02christian.heimessetmessageid: <1372294082.65.0.0208382829343.issue16487@psf.upfronthosting.co.za>
2013-06-27 00:48:02christian.heimeslinkissue16487 messages
2013-06-27 00:48:02christian.heimescreate