➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author serhiy.storchaka
Recipients akuchling, ezio.melotti, ishimoto, python-dev, serhiy.storchaka
Date 2013-06-17.14:06:27
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1371477988.0.0.0181779517201.issue18113@psf.upfronthosting.co.za>
In-reply-to
Content 
> I've attached a new version of the patch that does this check, and also adds a test.

You are right. Your patch LGTM.

> (OTOH, looking at the ncurses 5.9 source code, set_panel_userptr() only returns an error if the panel object is NULL, which should never happen because Python reports an error if the panel creation fails.  So maybe the rc == ERR check is pointless.)

Future versions or alternative implementations can returns an error in other circumstances.
History
Date User Action Args
2013-06-17 14:06:28serhiy.storchakasetrecipients: + serhiy.storchaka, akuchling, ishimoto, ezio.melotti, python-dev
2013-06-17 14:06:28serhiy.storchakasetmessageid: <1371477988.0.0.0181779517201.issue18113@psf.upfronthosting.co.za>
2013-06-17 14:06:27serhiy.storchakalinkissue18113 messages
2013-06-17 14:06:27serhiy.storchakacreate