This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author akuchling
Recipients akuchling, ezio.melotti, ishimoto, python-dev, serhiy.storchaka
Date 2013-06-16.23:14:16
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1371424456.81.0.466637236791.issue18113@psf.upfronthosting.co.za>
In-reply-to
Content
serhiy.storchaka: good point!  I wonder if, for strict correctness, we should only incref obj (the new object) if set_panel_userptr() returns OK and not an error code.  I've attached a new version of the patch that does this check, and also adds a test.

(OTOH, looking at the ncurses 5.9 source code, set_panel_userptr() only returns an error if the panel object is NULL, which should never happen because Python reports an error if the panel creation fails.  So maybe the rc == ERR check is pointless.)
History
Date User Action Args
2013-06-16 23:14:16akuchlingsetrecipients: + akuchling, ishimoto, ezio.melotti, python-dev, serhiy.storchaka
2013-06-16 23:14:16akuchlingsetmessageid: <1371424456.81.0.466637236791.issue18113@psf.upfronthosting.co.za>
2013-06-16 23:14:16akuchlinglinkissue18113 messages
2013-06-16 23:14:16akuchlingcreate