Message191297
serhiy.storchaka: good point! I wonder if, for strict correctness, we should only incref obj (the new object) if set_panel_userptr() returns OK and not an error code. I've attached a new version of the patch that does this check, and also adds a test.
(OTOH, looking at the ncurses 5.9 source code, set_panel_userptr() only returns an error if the panel object is NULL, which should never happen because Python reports an error if the panel creation fails. So maybe the rc == ERR check is pointless.) |
|
Date |
User |
Action |
Args |
2013-06-16 23:14:16 | akuchling | set | recipients:
+ akuchling, ishimoto, ezio.melotti, python-dev, serhiy.storchaka |
2013-06-16 23:14:16 | akuchling | set | messageid: <1371424456.81.0.466637236791.issue18113@psf.upfronthosting.co.za> |
2013-06-16 23:14:16 | akuchling | link | issue18113 messages |
2013-06-16 23:14:16 | akuchling | create | |
|