This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author roger.serwy
Recipients pitrou, roger.serwy, serhiy.storchaka, terry.reedy
Date 2013-03-31.19:26:42
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1364758002.29.0.140135593086.issue17585@psf.upfronthosting.co.za>
In-reply-to
Content
I agree with Antoine that fileno checking code should be removed. I dug deeper into why that was introduced in the first place.

00b136b7da84 introduced the warning "Trying to close unclosable fd!"
86358b43c8bb intoduced the change to site.py about not closing stdin if wrapping fd 0 to avoid the warning.
23d9cb777d9a removed the warning as part of issue4233.

So the code in site.py for checking fileno is cruft and can be safely removed. The site_reversion patch backs out of 86358b43c8bb.
History
Date User Action Args
2013-03-31 19:26:42roger.serwysetrecipients: + roger.serwy, terry.reedy, pitrou, serhiy.storchaka
2013-03-31 19:26:42roger.serwysetmessageid: <1364758002.29.0.140135593086.issue17585@psf.upfronthosting.co.za>
2013-03-31 19:26:42roger.serwylinkissue17585 messages
2013-03-31 19:26:42roger.serwycreate