Message183261
While writing the patch for issue 17327, I noticed that there is a double reference leak in dict_setdefault() under the rare condition that resizing fails. I'm not 100% sure that it's ok to move the increfs behind the resizing, but considering that the resizing code actually looks safe and shouldn't kill references that are currently in the dict, I don't think it can be a problem. And the caller should always own a reference to these two anyway. Alternatively, decrefing them if the failure occurs would be a less intrusive change. |
|
Date |
User |
Action |
Args |
2013-03-01 14:03:53 | scoder | set | recipients:
+ scoder |
2013-03-01 14:03:53 | scoder | set | messageid: <1362146633.78.0.0455037271826.issue17328@psf.upfronthosting.co.za> |
2013-03-01 14:03:53 | scoder | link | issue17328 messages |
2013-03-01 14:03:53 | scoder | create | |
|