This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author scoder
Recipients scoder
Date 2013-03-01.14:03:53
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1362146633.78.0.0455037271826.issue17328@psf.upfronthosting.co.za>
In-reply-to
Content
While writing the patch for issue 17327, I noticed that there is a double reference leak in dict_setdefault() under the rare condition that resizing fails. I'm not 100% sure that it's ok to move the increfs behind the resizing, but considering that the resizing code actually looks safe and shouldn't kill references that are currently in the dict, I don't think it can be a problem. And the caller should always own a reference to these two anyway. Alternatively, decrefing them if the failure occurs would be a less intrusive change.
History
Date User Action Args
2013-03-01 14:03:53scodersetrecipients: + scoder
2013-03-01 14:03:53scodersetmessageid: <1362146633.78.0.0455037271826.issue17328@psf.upfronthosting.co.za>
2013-03-01 14:03:53scoderlinkissue17328 messages
2013-03-01 14:03:53scodercreate