This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author orsenthil
Recipients ajaksu2, barry, fijall, flox, jepler, orsenthil, pitrou, rhettinger, serhiy.storchaka, tseaver
Date 2013-02-14.06:51:39
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <CAPOVWOT_-87A7O9rhUnxHFfZqEEABsgrfJ-Csj+kkc5uKXyu1w@mail.gmail.com>
In-reply-to <1360789520.86.0.572593654365.issue1285086@psf.upfronthosting.co.za>
Content
Applying this patch - I tried this hypothetical test.

$ ./python.exe -m timeit -s "import urllib.parse; x='a%20' * 100000"
"urllib.parse.unquote(x)"
10 loops, best of 3: 205 msec per loop

Without the patch, the above test will run for minutes!

This creates a significant difference for extremely long query
strings. For small strings the performance is negligible.

Serhiy: One question. Is there a need to have  -

+ append = res.append

And then use 'append'? res.append is easier for readability IMO.
Besides that I dont have any other comments. Maciej's comment could be
sought as he (correctly) brought up this issue.
History
Date User Action Args
2013-02-14 06:51:40orsenthilsetrecipients: + orsenthil, barry, jepler, rhettinger, tseaver, pitrou, ajaksu2, flox, fijall, serhiy.storchaka
2013-02-14 06:51:40orsenthillinkissue1285086 messages
2013-02-14 06:51:39orsenthilcreate