Message179354
Daniel, thanks for this patch, it looks very good. I had some comments in the code review.
As for TreeBuilder, let's split it into a separate issue - I think it's much less critical. We can discuss it later once we're done with Element. If anything, it's more important to handle ElementTree itself first - it should be very easy (much simpler than Element).
With the factory method I'm not sure how the Py pickling happens. I need to dig a bit in pickling for that, because I don't know how method reference pickling works. |
|
Date |
User |
Action |
Args |
2013-01-08 14:39:44 | eli.bendersky | set | recipients:
+ eli.bendersky, georg.brandl, jcea, larry, ezio.melotti, Arfrever, skrah, flox, santoso.wijaya, python-dev, einarfd, danielsh |
2013-01-08 14:39:43 | eli.bendersky | set | messageid: <1357655983.96.0.743600964042.issue16076@psf.upfronthosting.co.za> |
2013-01-08 14:39:43 | eli.bendersky | link | issue16076 messages |
2013-01-08 14:39:43 | eli.bendersky | create | |
|