This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author ezio.melotti
Recipients BreamoreBoy, brett.cannon, brian.curtin, dino.viehland, ezio.melotti, michael.foord, theller
Date 2012-11-18.21:42:17
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1353274939.28.0.91297469944.issue7855@psf.upfronthosting.co.za>
In-reply-to
Content
I made the latest 3.x patch hg import-able and cleaned up a few nits (whitespace, naming conventions, and used assertIs).
I have 2 comments though:
  1) the winreg test is defined in Win64WinregTests.  Is it specific to x64 or should it go in BaseWinregTests instead?
  2) the test_wintypes should be skipped on platforms where it's not supported.  Currently if I try to run test_ctypes I get:
test test_ctypes crashed -- Traceback (most recent call last):
  File "/home/wolf/dev/py/3.2/Lib/test/regrtest.py", line 1116, in runtest_inner
    indirect_test()
  File "/home/wolf/dev/py/3.2/Lib/test/test_ctypes.py", line 11, in test_main
    skipped, testcases = ctypes.test.get_tests(ctypes.test, "test_*.py", verbosity=0)
  File "/home/wolf/dev/py/3.2/Lib/ctypes/test/__init__.py", line 64, in get_tests
    mod = __import__(modname, globals(), locals(), ['*'])
  File "/home/wolf/dev/py/3.2/Lib/ctypes/test/test_wintypes.py", line 3, in <module>
    from ctypes import wintypes
  File "/home/wolf/dev/py/3.2/Lib/ctypes/wintypes.py", line 20, in <module>
    class VARIANT_BOOL(ctypes._SimpleCData):
ValueError: _type_ 'v' not supported

I get this error on 2.7/3.2/3.3/3.4 when I try to import wintypes.
Maybe this should be an ImportError instead?
Unfortunately I'm on Linux, so I can test and commit the patch myself, but feel free to address my comments and commit it.
History
Date User Action Args
2012-11-18 21:42:19ezio.melottisetrecipients: + ezio.melotti, brett.cannon, theller, dino.viehland, michael.foord, brian.curtin, BreamoreBoy
2012-11-18 21:42:19ezio.melottisetmessageid: <1353274939.28.0.91297469944.issue7855@psf.upfronthosting.co.za>
2012-11-18 21:42:19ezio.melottilinkissue7855 messages
2012-11-18 21:42:18ezio.melotticreate