Message 175331 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	gregory.p.smith
Recipients	asvetlov, bennoleslie, gregory.p.smith, rosslagerwall
Date	2012-11-11.08:53:42
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1352624023.23.0.375456270759.issue16140@psf.upfronthosting.co.za>
In-reply-to

Content
To remove the double close fd-reuse-window race condition you describe in 3.2.3 and later I don't think you even need to add that code snippet. Just get rid of the for loop calling os.close on those three fd's all together. self.stdin, self.stdout and self.stderr are already closed in the error case here: http://hg.python.org/releasing/3.2.3/file/86d1421a552c/Lib/subprocess.py#l746

To remove the double close fd-reuse-window race condition you describe in 3.2.3 and later I don't think you even need to add that code snippet.  Just get rid of the for loop calling os.close on those three fd's all together.  self.stdin, self.stdout and self.stderr are already closed in the error case here:

http://hg.python.org/releasing/3.2.3/file/86d1421a552c/Lib/subprocess.py#l746

History
Date	User	Action	Args
2012-11-11 08:53:43	gregory.p.smith	set	recipients: + gregory.p.smith, asvetlov, rosslagerwall, bennoleslie
2012-11-11 08:53:43	gregory.p.smith	set	messageid: <1352624023.23.0.375456270759.issue16140@psf.upfronthosting.co.za>
2012-11-11 08:53:43	gregory.p.smith	link	issue16140 messages
2012-11-11 08:53:42	gregory.p.smith	create