Message174927
I think the lru_cache should be kept if possible (i.e. I'm -0.5 on your patch). If this result in a slowdown (as the mako_v2 benchmark indicates), then there are two options:
1) optimize lru_cache;
2) avoid using it for regular expressions compiled with re.compile;
Both the changes should improve the performances.
This issue is about the re module, so I think it's ok to cover any changes to the re module here, and improvements to lru_cache (e.g. a faster make_key) should be moved to a new issue.
If this is not enough to restore the performances we might decide to go back to a custom cache instead of using lru_cache. |
|
Date |
User |
Action |
Args |
2012-11-05 18:30:05 | ezio.melotti | set | recipients:
+ ezio.melotti, barry, brett.cannon, rhettinger, ncoghlan, pitrou, pjenvey, zzzeek, serhiy.storchaka |
2012-11-05 18:30:05 | ezio.melotti | set | messageid: <1352140205.63.0.169596192108.issue16389@psf.upfronthosting.co.za> |
2012-11-05 18:30:05 | ezio.melotti | link | issue16389 messages |
2012-11-05 18:30:05 | ezio.melotti | create | |
|