Message174236
> Because it's much simpler like that.
Well, I wrote a patch with structure sequences, it is really much more expansive.
I have some comments.
1. You can allocate list of NUM_GENERATIONS elements and then use PyList_SET_ITEM(result, i, stat). This is 4 lines shorter.
2. And may be return the tuple? get_count() and get_threshold() return tuples.
3. You forgot to add get_stats() to the module docstring. |
|
Date |
User |
Action |
Args |
2012-10-30 22:56:01 | serhiy.storchaka | set | recipients:
+ serhiy.storchaka, gregory.p.smith, jcea, pitrou, christian.heimes, benjamin.peterson, python-dev |
2012-10-30 22:56:01 | serhiy.storchaka | set | messageid: <1351637761.92.0.831994903299.issue16351@psf.upfronthosting.co.za> |
2012-10-30 22:56:01 | serhiy.storchaka | link | issue16351 messages |
2012-10-30 22:56:01 | serhiy.storchaka | create | |
|