Message 168175 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	alexandre.vassalotti
Recipients	alexandre.vassalotti, mstefanro, pitrou
Date	2012-08-14.05:34:45
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1344922486.44.0.685594361951.issue15642@psf.upfronthosting.co.za>
In-reply-to

Content
I get warnings when compiling with the patch: /home/avassalotti/pickle4/Modules/_pickle.c: In function ‘save_global_binary’: /home/avassalotti/pickle4/Modules/_pickle.c:2952: warning: pointer targets in passing argument 2 of ‘_Pickler_Write’ differ in signedness /home/avassalotti/pickle4/Modules/_pickle.c:872: note: expected ‘const char ’ but argument is of type ‘unsigned char ’ /home/avassalotti/pickle4/Modules/_pickle.c:2956: warning: pointer targets in passing argument 2 of ‘_Pickler_Write’ differ in signedness /home/avassalotti/pickle4/Modules/_pickle.c:872: note: expected ‘const char ’ but argument is of type ‘unsigned char ’ /home/avassalotti/pickle4/Modules/_pickle.c:2960: warning: pointer targets in passing argument 2 of ‘_Pickler_Write’ differ in signedness /home/avassalotti/pickle4/Modules/_pickle.c:872: note: expected ‘const char ’ but argument is of type ‘unsigned char ’ /home/avassalotti/pickle4/Modules/_pickle.c:2975: warning: pointer targets in passing argument 2 of ‘_Pickler_Write’ differ in signedness /home/avassalotti/pickle4/Modules/_pickle.c:872: note: expected ‘const char ’ but argument is of type ‘unsigned char ’ /home/avassalotti/pickle4/Modules/_pickle.c:2979: warning: pointer targets in passing argument 2 of ‘_Pickler_Write’ differ in signedness /home/avassalotti/pickle4/Modules/_pickle.c:872: note: expected ‘const char ’ but argument is of type ‘unsigned char ’ /home/avassalotti/pickle4/Modules/_pickle.c:2988: warning: pointer targets in passing argument 2 of ‘_Pickler_Write’ differ in signedness /home/avassalotti/pickle4/Modules/_pickle.c:872: note: expected ‘const char ’ but argument is of type ‘unsigned char ’ /home/avassalotti/pickle4/Modules/_pickle.c:3012: warning: pointer targets in passing argument 2 of ‘_Pickler_Write’ differ in signedness /home/avassalotti/pickle4/Modules/_pickle.c:872: note: expected ‘const char ’ but argument is of type ‘unsigned char ’ /home/avassalotti/pickle4/Modules/_pickle.c: In function ‘save_set’: /home/avassalotti/pickle4/Modules/_pickle.c:3368: warning: suggest parentheses around assignment used as truth value /home/avassalotti/pickle4/Modules/_pickle.c: In function ‘save_frozenset’: /home/avassalotti/pickle4/Modules/_pickle.c:3422: warning: suggest parentheses around assignment used as truth value These should be fixed.

I get warnings when compiling with the patch:


/home/avassalotti/pickle4/Modules/_pickle.c: In function ‘save_global_binary’:
/home/avassalotti/pickle4/Modules/_pickle.c:2952: warning: pointer targets in passing argument 2 of ‘_Pickler_Write’ differ in signedness
/home/avassalotti/pickle4/Modules/_pickle.c:872: note: expected ‘const char *’ but argument is of type ‘unsigned char *’
/home/avassalotti/pickle4/Modules/_pickle.c:2956: warning: pointer targets in passing argument 2 of ‘_Pickler_Write’ differ in signedness
/home/avassalotti/pickle4/Modules/_pickle.c:872: note: expected ‘const char *’ but argument is of type ‘unsigned char *’
/home/avassalotti/pickle4/Modules/_pickle.c:2960: warning: pointer targets in passing argument 2 of ‘_Pickler_Write’ differ in signedness
/home/avassalotti/pickle4/Modules/_pickle.c:872: note: expected ‘const char *’ but argument is of type ‘unsigned char *’
/home/avassalotti/pickle4/Modules/_pickle.c:2975: warning: pointer targets in passing argument 2 of ‘_Pickler_Write’ differ in signedness
/home/avassalotti/pickle4/Modules/_pickle.c:872: note: expected ‘const char *’ but argument is of type ‘unsigned char *’
/home/avassalotti/pickle4/Modules/_pickle.c:2979: warning: pointer targets in passing argument 2 of ‘_Pickler_Write’ differ in signedness
/home/avassalotti/pickle4/Modules/_pickle.c:872: note: expected ‘const char *’ but argument is of type ‘unsigned char *’
/home/avassalotti/pickle4/Modules/_pickle.c:2988: warning: pointer targets in passing argument 2 of ‘_Pickler_Write’ differ in signedness
/home/avassalotti/pickle4/Modules/_pickle.c:872: note: expected ‘const char *’ but argument is of type ‘unsigned char *’
/home/avassalotti/pickle4/Modules/_pickle.c:3012: warning: pointer targets in passing argument 2 of ‘_Pickler_Write’ differ in signedness
/home/avassalotti/pickle4/Modules/_pickle.c:872: note: expected ‘const char *’ but argument is of type ‘unsigned char *’
/home/avassalotti/pickle4/Modules/_pickle.c: In function ‘save_set’:
/home/avassalotti/pickle4/Modules/_pickle.c:3368: warning: suggest parentheses around assignment used as truth value
/home/avassalotti/pickle4/Modules/_pickle.c: In function ‘save_frozenset’:
/home/avassalotti/pickle4/Modules/_pickle.c:3422: warning: suggest parentheses around assignment used as truth value


These should be fixed.

History
Date	User	Action	Args
2012-08-14 05:34:46	alexandre.vassalotti	set	recipients: + alexandre.vassalotti, pitrou, mstefanro
2012-08-14 05:34:46	alexandre.vassalotti	set	messageid: <1344922486.44.0.685594361951.issue15642@psf.upfronthosting.co.za>
2012-08-14 05:34:45	alexandre.vassalotti	link	issue15642 messages
2012-08-14 05:34:45	alexandre.vassalotti	create