This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author loewis
Recipients benjamin.peterson, loewis, ncoghlan, serhiy.storchaka
Date 2012-07-26.20:18:21
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1343333902.86.0.211659786457.issue15456@psf.upfronthosting.co.za>
In-reply-to
Content
Interestingly, the original patch did change the sizeof test, but incorrectly (adding the extra pointer to the struct spec, but failing to recognize that there is additional memory allocated).

This tells me

a) we *absolutely* need to preserve the current testing style where the test cases count the individual fields (see issue15402 for the related discussion). Had the test used object.__sizeof__, it would not have needed any change to continue to pass, losing all hope that somebody might have detected it except by very careful review.

b) the trigger that the test broke apparently was not sufficient to hint Benjamin that the sizeof implementation may be incorrect, he just assumed that the test was incorrect.
History
Date User Action Args
2012-07-26 20:18:22loewissetrecipients: + loewis, ncoghlan, benjamin.peterson, serhiy.storchaka
2012-07-26 20:18:22loewissetmessageid: <1343333902.86.0.211659786457.issue15456@psf.upfronthosting.co.za>
2012-07-26 20:18:22loewislinkissue15456 messages
2012-07-26 20:18:21loewiscreate