Message165930
Thanks for the review ezio.melotti.
He has notice a few things in my patch:
* assertEquals is deprecated; should use assertEqual
* the convention is assertEqual(result, expected), not assertEqual(expected, result)
* it should handle quotes correctly
* some lines were longer than 80 chars
* add tests using inline flags (re.I instead of re.IGNORECASE)
And I realized I was not covering the case where no flags are enabled (byte string, for instance). And I have fixed all this issues.
And now I think this patch would work against py2x and py3k anyway.
Attaching a new patch. |
|
Date |
User |
Action |
Args |
2012-07-20 14:29:33 | hltbra | set | recipients:
+ hltbra, rhettinger, terry.reedy, pitrou, ezio.melotti, mrabarnett, alex, eric.snow, dwt |
2012-07-20 14:29:33 | hltbra | set | messageid: <1342794573.02.0.344858852798.issue13592@psf.upfronthosting.co.za> |
2012-07-20 14:29:32 | hltbra | link | issue13592 messages |
2012-07-20 14:29:32 | hltbra | create | |
|