This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author ncoghlan
Recipients loewis, ncoghlan, pitrou
Date 2012-06-23.05:59:53
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1340431215.31.0.910582474537.issue15142@psf.upfronthosting.co.za>
In-reply-to
Content
That does look like it will fix the leak, but now I'm actually thinking there's more code from type_new that should also be executed in the PyType_FromSpec case.

I mean things like:
- ensuring __new__ is a static method
- ensuring the standard attribute lookup machinery is configured
- hooking up tp_as_number, tp_as_mapping, etc
- ensuring GC support is configured correctly

If that's all happening somehow, it could use a comment, because I certainly can't see it.

If not, we probably need to factor out some helper functions that type_new and PyType_FromSpec can both call to make sure everything is fully configured.
History
Date User Action Args
2012-06-23 06:00:15ncoghlansetrecipients: + ncoghlan, loewis, pitrou
2012-06-23 06:00:15ncoghlansetmessageid: <1340431215.31.0.910582474537.issue15142@psf.upfronthosting.co.za>
2012-06-23 05:59:54ncoghlanlinkissue15142 messages
2012-06-23 05:59:53ncoghlancreate