Message160177
Comments on the patch.
-PyAPI_FUNC(PyObject *) _PyComplex_FormatAdvanced(PyObject *obj,
+PyAPI_FUNC(int) _PyComplex_FormatWriter(PyObject *obj,
Even if it is a private function, I prefer to rename it because its API does change.
/* Use the inlined version in unicodeobject.c */
#define _PyUnicodeWriter_prepare _PyUnicodeWriter_prepare_inline
#define _PyUnicodeWriter_write_substr _PyUnicodeWriter_write_substr_inline
#define _PyUnicodeWriter_write_str _PyUnicodeWriter_write_str_inline
#define _PyUnicodeWriter_write_char _PyUnicodeWriter_write_char_inline
Inlining may be removed to simplify the code (but inlining does speed up the code a little bit). Or the opposite: this code should be moved to a new "unicodewriterinline.h" file which would be included by unicodeobject.c and formatter_unicode.c. |
|
Date |
User |
Action |
Args |
2012-05-07 22:19:42 | vstinner | set | recipients:
+ vstinner, loewis, pitrou, serhiy.storchaka |
2012-05-07 22:19:42 | vstinner | set | messageid: <1336429182.09.0.719303000192.issue14744@psf.upfronthosting.co.za> |
2012-05-07 22:19:41 | vstinner | link | issue14744 messages |
2012-05-07 22:19:41 | vstinner | create | |
|