This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author mark.dickinson
Recipients eric.smith, jcea, mark.dickinson, python-dev, samuel.iseli, skrah
Date 2012-04-15.12:03:26
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1334491407.25.0.75822673999.issue13889@psf.upfronthosting.co.za>
In-reply-to
Content
Slightly reworked patch.  I plan to apply this shortly.

- Use ~(_MCW_PC | _MCW_RC) rather than (_MCW_DN | ...), since this seems more future proof:  there's a possibility that more flags could be added later.

- Put the usual do { ... } while (0) around the _Py_SET_53BIT_PRECISION_END

- Make it clear that we don't care about the return value of the second two __control87_2 patches.

- Minor style fixes (e.g., spaces around a "bitwise and" ampersand to help distinguish it from an "address of" ampersand).


I'm not too worried about the fenv_access pragma:  it seems that the main thing it would guard against is compile-time folding and evaluation of expressions, where the compiler isn't taking the possibility of control word changes into account.  As far as I can tell, we shouldn't really care about this, since at the time that Python itself is compiled, the control word is likely to be what we want.
History
Date User Action Args
2012-04-15 12:03:27mark.dickinsonsetrecipients: + mark.dickinson, jcea, eric.smith, skrah, python-dev, samuel.iseli
2012-04-15 12:03:27mark.dickinsonsetmessageid: <1334491407.25.0.75822673999.issue13889@psf.upfronthosting.co.za>
2012-04-15 12:03:26mark.dickinsonlinkissue13889 messages
2012-04-15 12:03:26mark.dickinsoncreate