Message157697
> Here is a new patch, with more tests.
> Note that the process worker function can't be a member function
> because of how multiprocessing works on Windows.
Some comments:
- I said classmethod, not member function; this is how
test_multiprocessing works, so it should be possible...
- why did you change the gethostbyname() tests?
- before using AF_INET6, you might have to test that IPv6 is available
on the test machine (I think there are variables / functions for that in
test_socket)
- in compareSockets:
+ if org.proto != 0:
+ self.assertEqual(sock.proto, other.proto)
`sock` doesn't seem to exist at all... |
|
Date |
User |
Action |
Args |
2012-04-06 21:48:14 | pitrou | set | recipients:
+ pitrou, kristjan.jonsson, giampaolo.rodola, santoso.wijaya, sbt |
2012-04-06 21:48:14 | pitrou | link | issue14310 messages |
2012-04-06 21:48:13 | pitrou | create | |
|