Message157573
New version:
- if __build_class__ is missing, raise a NameError instead of surprising ImportError
- add tests
- if PyObject_GetItem on __builtins__ or globals fail, only raise NameError if the exception is a KeyError
Before my patch, a new dict was created for builtins if __builtins__ exists in global but is not a dict. With my patch, the __builtins__ is kept and the type is checked at runtime. If __builtins__ is not a mapping, an exception is raised on lookup in ceval.c.
We may check __builtins__ type in PyFrame_New() using:
PyDict_Check(builtins) || (PyMapping_Check(mapping) && !PyList_Check(mapping) && !PyTuple_Check(mapping))
(PyDict_Check(builtins) is checked first for performance) |
|
Date |
User |
Action |
Args |
2012-04-05 12:09:42 | vstinner | set | recipients:
+ vstinner |
2012-04-05 12:09:42 | vstinner | set | messageid: <1333627782.45.0.741262125731.issue14385@psf.upfronthosting.co.za> |
2012-04-05 12:09:41 | vstinner | link | issue14385 messages |
2012-04-05 12:09:41 | vstinner | create | |
|