Message156803
I've just started looking at this. Nice job and good attention to detail on the error checking. Expect to have a few high-level suggestions and a ton of minor edits.
Here are a couple of quick thoughts:
* The comment style needs to switch to the /* style */
* Use the pure python _cache_info by looking it up on the module object.
* I had expected PyList objects rather than links between C structs (following the pure python lru_cache as closely as possible). |
|
Date |
User |
Action |
Args |
2012-03-26 08:29:56 | rhettinger | set | recipients:
+ rhettinger, giampaolo.rodola, nedbat, meador.inge, anacrolix |
2012-03-26 08:29:56 | rhettinger | set | messageid: <1332750596.21.0.343671032397.issue14373@psf.upfronthosting.co.za> |
2012-03-26 08:29:55 | rhettinger | link | issue14373 messages |
2012-03-26 08:29:55 | rhettinger | create | |
|