Message 156075 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	r.david.murray
Recipients	Jason.Killen, fruitnuke, giampaolo.rodola, r.david.murray
Date	2012-03-16.20:17:55
SpamBayes Score	4.6112228e-07
Marked as misclassified	No
Message-id	<1331929076.93.0.414447734881.issue14269@psf.upfronthosting.co.za>
In-reply-to

Content
Thanks for the patch. I think this is fine. An alternate approach would be to introduce the concept of a state (like imaplib has), have a list of which commands are allowed in which state, and implement the check in the command processing function, but that may not be worth it at smtpd's current level of complexity. One change I'd like to see in the patch (and test): postfix in this case responds: 503 Error: send HELO/EHLO first And I think that is more useful than the text 'Bad sequence of commands'.

Thanks for the patch.

I think this is fine.

An alternate approach would be to introduce the concept of a state (like imaplib has), have a list of which commands are allowed in which state, and implement the check in the command processing function, but that may not be worth it at smtpd's current level of complexity.

One change I'd like to see in the patch (and test): postfix in this case responds:

  503 Error: send HELO/EHLO first

And I think that is more useful than the text 'Bad sequence of commands'.

History
Date	User	Action	Args
2012-03-16 20:17:56	r.david.murray	set	recipients: + r.david.murray, giampaolo.rodola, fruitnuke, Jason.Killen
2012-03-16 20:17:56	r.david.murray	set	messageid: <1331929076.93.0.414447734881.issue14269@psf.upfronthosting.co.za>
2012-03-16 20:17:56	r.david.murray	link	issue14269 messages
2012-03-16 20:17:55	r.david.murray	create