This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author nadeem.vawda
Recipients Adam.Groszer, benjamin.peterson, cjw296, eric.araujo, georg.brandl, jaraco, nadeem.vawda, tarek
Date 2012-02-25.08:10:22
SpamBayes Score 0.00016370222
Marked as misclassified No
Message-id <1330157423.05.0.337465638202.issue6884@psf.upfronthosting.co.za>
In-reply-to
Content
>> - test_glob_to_re() was doing two levels of escaping (r'\' -> r'\\\\')
>>   for its expected output when it should only do one (r'\' -> r'\\').
> Fix merged.  I don’t fully understand why one place needs two escapes and the others just one.

I agree that this code is confusing, though. Perhaps we should add a
comment in glob_to_re():

    # Warning - manipulating a regex with a regex. Here be dragons.

;-)
History
Date User Action Args
2012-02-25 08:10:23nadeem.vawdasetrecipients: + nadeem.vawda, georg.brandl, jaraco, cjw296, benjamin.peterson, tarek, eric.araujo, Adam.Groszer
2012-02-25 08:10:23nadeem.vawdasetmessageid: <1330157423.05.0.337465638202.issue6884@psf.upfronthosting.co.za>
2012-02-25 08:10:22nadeem.vawdalinkissue6884 messages
2012-02-25 08:10:22nadeem.vawdacreate