Author dmalcolm
Recipients Arach, Arfrever, Huzaifa.Sidhpurwala, Jim.Jewett, Mark.Shannon, PaulMcMillan, Zhiping.Deng, alex, barry, benjamin.peterson, christian.heimes, dmalcolm, eric.snow, fx5, georg.brandl, grahamd, gregory.p.smith, gvanrossum, gz, haypo, jcea, lemburg, loewis, mark.dickinson, merwok, neologix, pitrou, skorgu, skrah, terry.reedy, tim.peters, v+python, zbysz
Date 2012-02-13.20:37:12
SpamBayes Score 0.0
Marked as misclassified No
Message-id <1329165382.27728.1.camel@surprise>
In-reply-to <1329012688.13.0.62888644637.issue13703@psf.upfronthosting.co.za>
Content
On Sun, 2012-02-12 at 02:11 +0000, Gregory P. Smith wrote:
> Gregory P. Smith <greg@krypto.org> added the comment:
> 
> Comments to be addressed added on the code review.

Thanks.  I'm attaching new patches:
  add-randomization-to-2.6-dmalcolm-2012-02-13-001.patch
  add-randomization-to-3.1-dmalcolm-2012-02-13-001.patch

I incorporated the feedback from Gregory P Smith's review.

I haven't changed the way the command-line options or env variables
work, though.

Changes relative to *-2012-02-11-001.patch:
  * added versionadded 2.6.8 and 3.1.5 to hash_randomization/-R within
Docs/library/sys.rst and Docs/using/cmdline.rst (these will need
changing to "2.7.3" and "3.2.3" in the forward ports to the 2.7 and 3.2
branches)
  * fixed line wrapping within the --help text in Modules/main.c
  * reverted text of urandom__doc__
  * added comments about the specialcasing of length 0:
    /*
      We make the hash of the empty string be 0, rather than using
      (prefix ^ suffix), since this slightly obfuscates the hash secret
    */
    (see discussion in http://bugs.python.org/issue13703#msg151664
onwards)

I didn't change the range of values for PYTHONHASHSEED on 64-bit
Files
File name Uploaded
add-randomization-to-2.6-dmalcolm-2012-02-13-001.patch dmalcolm, 2012-02-13.20:37:04
add-randomization-to-3.1-dmalcolm-2012-02-13-001.patch dmalcolm, 2012-02-13.20:37:08
History
Date User Action Args
2012-02-13 20:37:17dmalcolmsetrecipients: + dmalcolm, lemburg, gvanrossum, tim.peters, loewis, barry, georg.brandl, terry.reedy, gregory.p.smith, jcea, mark.dickinson, pitrou, haypo, christian.heimes, benjamin.peterson, merwok, grahamd, Arfrever, v+python, alex, zbysz, skrah, gz, neologix, Arach, Mark.Shannon, eric.snow, Zhiping.Deng, Huzaifa.Sidhpurwala, Jim.Jewett, PaulMcMillan, fx5, skorgu
2012-02-13 20:37:13dmalcolmlinkissue13703 messages
2012-02-13 20:37:12dmalcolmcreate