➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author roger.serwy
Recipients doko, eric.araujo, gpolo, kbk, ned.deily, roger.serwy, terry.reedy
Date 2012-02-05.16:35:26
SpamBayes Score 0.001267887
Marked as misclassified No
Message-id <1328459727.44.0.827539116257.issue964437@psf.upfronthosting.co.za>
In-reply-to
Content 
Those four lines are present just in case self.root is not initialized. 
Even if you short-circuit the behavior and set parent=self.top, the patch still works, only that closing the calling EditorWindow instance also closes the help dialog. 

I tested the patch against 3.3a0 on Ubuntu and 3.2.2 on Vista and it does attach to root, not self.top. 

It sounds like remnants of "_singledialog" are present in EditorWindow.py. Did you back out of the previous patch before applying help_nonmodal_revision.patch?
History
Date User Action Args
2012-02-05 16:35:27roger.serwysetrecipients: + roger.serwy, terry.reedy, doko, kbk, gpolo, ned.deily, eric.araujo
2012-02-05 16:35:27roger.serwysetmessageid: <1328459727.44.0.827539116257.issue964437@psf.upfronthosting.co.za>
2012-02-05 16:35:26roger.serwylinkissue964437 messages
2012-02-05 16:35:26roger.serwycreate