This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author joneskoo
Recipients carljm, ezio.melotti, jcea, joneskoo, maker, orsenthil
Date 2012-01-10.07:01:46
SpamBayes Score 4.6035157e-07
Marked as misclassified No
Message-id <1326178908.28.0.554576587376.issue13642@psf.upfronthosting.co.za>
In-reply-to
Content
Michele, in your patch:

+            authorization = ("Authorization: Basic %s\r\n" %
+                             b64encode('a%20b:c%20d'))

This is wrong. See the original report by me and RFC 2617. The username and password MUST NOT be url encoded before base64. That is the original problem. The point is that this test should fail with urllib before the change and not fail with the fix.

Secondly, I think unquote will fail when given a None. For me, some other unit tests caught this when I had the unquote where the splituser is called. I didn't run your code but are other urllib tests ok for you?

I like your change of having the base64 explicitly there and not as a magic string is a good idea.

Senthil, could you provide the better alternative for the class field abuse, please?
History
Date User Action Args
2012-01-10 07:01:48joneskoosetrecipients: + joneskoo, jcea, orsenthil, carljm, ezio.melotti, maker
2012-01-10 07:01:48joneskoosetmessageid: <1326178908.28.0.554576587376.issue13642@psf.upfronthosting.co.za>
2012-01-10 07:01:47joneskoolinkissue13642 messages
2012-01-10 07:01:47joneskoocreate