This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author anacrolix
Recipients anacrolix, giampaolo.rodola, josiahcarlson, rosslagerwall, stutzbach
Date 2012-01-03.00:42:50
SpamBayes Score 3.950463e-07
Marked as misclassified No
Message-id <1325551370.93.0.887366175636.issue13694@psf.upfronthosting.co.za>
In-reply-to
Content
I don't believe it is. dispatcher.addr is only set if the connection is immediately established. It's set explicitly in dispatcher.__init__ if a socket is provided that is already connected. It's *not* set after a connection completes.

There are 2 solutions as I see it:

1) Set addr after a successful call to socket.connect indicates that a connection is being established. Currently this only occurs if the connection is not delayed.
2) Set the addr when a connect event completes. This would require making getpeername calls like in dispatcher.__init__ and would be significantly more expensive.

My patch implements method 1. This conforms to existing addr-setting behaviour in dispatcher.bind.
History
Date User Action Args
2012-01-03 00:42:50anacrolixsetrecipients: + anacrolix, josiahcarlson, giampaolo.rodola, stutzbach, rosslagerwall
2012-01-03 00:42:50anacrolixsetmessageid: <1325551370.93.0.887366175636.issue13694@psf.upfronthosting.co.za>
2012-01-03 00:42:50anacrolixlinkissue13694 messages
2012-01-03 00:42:50anacrolixcreate