Message148633
Since it's a performance improvement, it's Python 3.3-only.
The patch looks ok but there's an unrelated issue. If I first pickle a bytearray under 3.3 using protocol 2:
>>> b = bytearray(b'xyz')
>>> pickle.dumps(b, protocol=2)
b'\x80\x02c__builtin__\nbytearray\nq\x00c__builtin__\nbytes\nq\x01]q\x02(KxKyKze\x85q\x03Rq\x04\x85q\x05Rq\x06.'
and then unpickle it under 2.7, I get:
>>> pickle.loads(b'\x80\x02c__builtin__\nbytearray\nq\x00c__builtin__\nbytes\nq\x01]q\x02(KxKyKze\x85q\x03Rq\x04\x85q\x05Rq\x06.')
bytearray(b'[120, 121, 122]')
... which is wrong. It seems pickling bytes objects with protocol 2 and unpickling them with Python 2.x is broken. |
|
Date |
User |
Action |
Args |
2011-11-30 02:07:08 | pitrou | set | recipients:
+ pitrou, irmen, alexandre.vassalotti |
2011-11-30 02:07:08 | pitrou | set | messageid: <1322618828.87.0.23381690286.issue13503@psf.upfronthosting.co.za> |
2011-11-30 02:07:08 | pitrou | link | issue13503 messages |
2011-11-30 02:07:07 | pitrou | create | |
|