This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author nadeem.vawda
Recipients Christophe Simonis, Garen, Nam.Nguyen, amaury.forgeotdarc, arekm, asvetlov, barry, doko, eric.araujo, georg.brandl, jcea, jeremybanks, jreese, lars.gustaebel, leonov, loewis, nadeem.vawda, nicdumz, nikratio, ockham-razor, pitrou, proyvind, rcoyner, shirish, strombrg, thedjatclubrock, tshepang, ysj.ray
Date 2011-09-09.08:08:24
SpamBayes Score 6.1221406e-05
Marked as misclassified No
Message-id <1315555705.84.0.496589960741.issue6715@psf.upfronthosting.co.za>
In-reply-to
Content
> In uint32_converter, I'm not sure the if statement comparing val and
> UINT32_MAX makes sense. val was defined to be unsigned long, which is
> 32bit on 32-bit compiler.

Yes, on a 32-bit system, this comparison will always be false. However,
on a 64-bit system, an unsigned long will (usually) be 64 bits wide. In
this case, we do need to check that the value fits into a uint32_t.
History
Date User Action Args
2011-09-09 08:08:25nadeem.vawdasetrecipients: + nadeem.vawda, loewis, barry, georg.brandl, doko, jcea, amaury.forgeotdarc, arekm, lars.gustaebel, pitrou, nicdumz, eric.araujo, Christophe Simonis, rcoyner, proyvind, asvetlov, nikratio, leonov, Garen, ysj.ray, thedjatclubrock, ockham-razor, jreese, strombrg, shirish, tshepang, jeremybanks, Nam.Nguyen
2011-09-09 08:08:25nadeem.vawdasetmessageid: <1315555705.84.0.496589960741.issue6715@psf.upfronthosting.co.za>
2011-09-09 08:08:25nadeem.vawdalinkissue6715 messages
2011-09-09 08:08:24nadeem.vawdacreate