This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author vinay.sajip
Recipients alexis, eric.araujo, tarek, trevor, vinay.sajip
Date 2011-09-01.12:35:12
SpamBayes Score 5.539018e-06
Marked as misclassified No
Message-id <1314880513.71.0.492127086476.issue12386@psf.upfronthosting.co.za>
In-reply-to
Content
@Éric: I also noticed that your latest comment 

"All text is bytes, so we can do all I/O in bytes when writing resources and avoid special-casing."

contradicts your earlier position:

"I agree about the nonsense of opening in binary mode."

If using text mode, we might lose any specific encoding used for the source script unless we do encoding-detection as the interpreter does, and preserve that across the change-shebang-and-save. Using binary does avoid this, and should be doable with simpler code, so perhaps it is preferable - as long as we do it correctly so as to avoid the TypeError :-)
History
Date User Action Args
2011-09-01 12:35:13vinay.sajipsetrecipients: + vinay.sajip, tarek, eric.araujo, alexis, trevor
2011-09-01 12:35:13vinay.sajipsetmessageid: <1314880513.71.0.492127086476.issue12386@psf.upfronthosting.co.za>
2011-09-01 12:35:13vinay.sajiplinkissue12386 messages
2011-09-01 12:35:12vinay.sajipcreate