Message140710
Le mardi 19 juillet 2011 à 23:20 +0000, STINNER Victor a écrit :
> STINNER Victor <victor.stinner@haypocalc.com> added the comment:
>
> > Your patch looks fine to me, except for this:
> > - if (platform in ('linux2', 'freebsd4', 'freebsd5', 'freebsd6',
> > - 'freebsd7', 'freebsd8')
> > - or platform.startswith("gnukfreebsd")):
> > + if os.uname()[0] in ('Linux', 'FreeBSD'):
> >
> > Why not use platform.system(), to be consistent?
>
> I'm not sure that thp platform module can be used in setup.py
> (bootstrap issue?). It should be tested.
Why don't you just use platform.startswith? It would avoid introducing
bugs due to subtle differences between uname, platform or
platform.system. |
|
Date |
User |
Action |
Args |
2011-07-19 23:26:17 | pitrou | set | recipients:
+ pitrou, lemburg, loewis, doko, amaury.forgeotdarc, vstinner, jwilk, djc, ezio.melotti, eric.araujo, Arfrever, r.david.murray, neologix, rosslagerwall, python-dev, petri.lehtinen |
2011-07-19 23:26:16 | pitrou | link | issue12326 messages |
2011-07-19 23:26:16 | pitrou | create | |
|