Author pitrou
Recipients Arfrever, amaury.forgeotdarc, djc, doko, ezio.melotti, haypo, jwilk, lemburg, loewis, merwok, neologix, petri.lehtinen, pitrou, python-dev, r.david.murray, rosslagerwall
Date 2011-07-19.23:26:16
SpamBayes Score 1.93231e-08
Marked as misclassified No
Message-id <1311117894.3618.6.camel@localhost.localdomain>
In-reply-to <201107200119.38808.victor.stinner@haypocalc.com>
Content
Le mardi 19 juillet 2011 à 23:20 +0000, STINNER Victor a écrit :
> STINNER Victor <victor.stinner@haypocalc.com> added the comment:
> 
> > Your patch looks fine to me, except for this:
> > -        if (platform in ('linux2', 'freebsd4', 'freebsd5', 'freebsd6',
> > -                        'freebsd7', 'freebsd8')
> > -            or platform.startswith("gnukfreebsd")):
> > +        if os.uname()[0] in ('Linux', 'FreeBSD'):
> > 
> > Why not use platform.system(), to be consistent?
> 
> I'm not sure that thp platform module can be used in setup.py 
> (bootstrap issue?). It should be tested.

Why don't you just use platform.startswith? It would avoid introducing
bugs due to subtle differences between uname, platform or
platform.system.
History
Date User Action Args
2011-07-19 23:26:17pitrousetrecipients: + pitrou, lemburg, loewis, doko, amaury.forgeotdarc, haypo, jwilk, djc, ezio.melotti, merwok, Arfrever, r.david.murray, neologix, rosslagerwall, python-dev, petri.lehtinen
2011-07-19 23:26:16pitroulinkissue12326 messages
2011-07-19 23:26:16pitroucreate