Author haypo
Recipients Arfrever, amaury.forgeotdarc, djc, doko, ezio.melotti, haypo, jwilk, lemburg, loewis, merwok, neologix, petri.lehtinen, pitrou, python-dev, r.david.murray, rosslagerwall
Date 2011-07-19.23:20:34
SpamBayes Score 2.77341e-06
Marked as misclassified No
Message-id <201107200119.38808.victor.stinner@haypocalc.com>
In-reply-to <CAH_1eM3X-Lir_5KLvF2O6m2EMxPdPnAUPRkygQ5RVxO8mCPicQ@mail.gmail.com>
Content
> Your patch looks fine to me, except for this:
> -        if (platform in ('linux2', 'freebsd4', 'freebsd5', 'freebsd6',
> -                        'freebsd7', 'freebsd8')
> -            or platform.startswith("gnukfreebsd")):
> +        if os.uname()[0] in ('Linux', 'FreeBSD'):
> 
> Why not use platform.system(), to be consistent?

I'm not sure that thp platform module can be used in setup.py 
(bootstrap issue?). It should be tested.
History
Date User Action Args
2011-07-19 23:20:35hayposetrecipients: + haypo, lemburg, loewis, doko, amaury.forgeotdarc, pitrou, jwilk, djc, ezio.melotti, merwok, Arfrever, r.david.murray, neologix, rosslagerwall, python-dev, petri.lehtinen
2011-07-19 23:20:34haypolinkissue12326 messages
2011-07-19 23:20:34haypocreate