Author neologix
Recipients Arfrever, amaury.forgeotdarc, djc, doko, ezio.melotti, haypo, jwilk, lemburg, loewis, merwok, neologix, petri.lehtinen, pitrou, python-dev, r.david.murray, rosslagerwall
Date 2011-07-19.17:52:05
SpamBayes Score 1.56575e-10
Marked as misclassified No
Message-id <CAH_1eM3X-Lir_5KLvF2O6m2EMxPdPnAUPRkygQ5RVxO8mCPicQ@mail.gmail.com>
In-reply-to <1310719010.29.0.524397451586.issue12326@psf.upfronthosting.co.za>
Content
> I'm still in favor of keeping sys.platform == 'linux3', and you?
>

So do I.

> For plat-linux3, should we regenerate this directory (I cannot do that, I
> don't have Linux 3.0 yet) or can we just use a symbolic link? I read that
> Linux 3.0 doesn't break the API, so I suppose that constants are the same.
> Or can we try by copying plat-linux2 to plat-linux3?
>

I've just had a quick look, but it seems that plat-<sys.platform>
contains header definitions, so it's more function of the libc than
the kernel version. It probably makes sense on operating systems which
have a real notion of release (i.e. a consistent kernel/user-space,
like AIX or *BSD), but not so much on Linux. Copying plat-linux2 to
plat-linux3 should be just fine.

Your patch looks fine to me, except for this:
-        if (platform in ('linux2', 'freebsd4', 'freebsd5', 'freebsd6',
-                        'freebsd7', 'freebsd8')
-            or platform.startswith("gnukfreebsd")):
+        if os.uname()[0] in ('Linux', 'FreeBSD'):

Why not use platform.system(), to be consistent?
History
Date User Action Args
2011-07-19 17:52:09neologixsetrecipients: + neologix, lemburg, loewis, doko, amaury.forgeotdarc, pitrou, haypo, jwilk, djc, ezio.melotti, merwok, Arfrever, r.david.murray, rosslagerwall, python-dev, petri.lehtinen
2011-07-19 17:52:05neologixlinkissue12326 messages
2011-07-19 17:52:05neologixcreate