This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author vstinner
Recipients amaury.forgeotdarc, brian.curtin, loewis, tim.golden, vstinner
Date 2011-06-22.21:14:54
SpamBayes Score 5.6837255e-08
Marked as misclassified No
Message-id <1308777296.18.0.478796268236.issue9642@psf.upfronthosting.co.za>
In-reply-to
Content
have_mbcs.patch: use HAVE_MBCS define instead of different tests to check if the MBCS codec can be used or not. HAVE_MBCS is defined in unicodeobject.h by:

#if defined(MS_WINDOWS) && defined(HAVE_USABLE_WCHAR_T)
#  define HAVE_MBCS
#endif

> > We should just check that we are compiling under Windows:

> -1, see above. In the long run, it would be really good if Python
> supported a four-byte Py_UNICODE on Windows - people keep asking
> for it.

MBCS functions of the Python API are always available on Windows without my patch. I don't know if it's correct or not. Using my patch, they are not available if HAVE_USABLE_WCHAR_T is not defined.

Support 32 bits Py_UNICODE on Windows requires a lot of work because in *many* places (everywhere?) Py_UNICODE* is used as wchar_t*. But it is not the topic of this issue :-)
History
Date User Action Args
2011-06-22 21:14:56vstinnersetrecipients: + vstinner, loewis, amaury.forgeotdarc, tim.golden, brian.curtin
2011-06-22 21:14:56vstinnersetmessageid: <1308777296.18.0.478796268236.issue9642@psf.upfronthosting.co.za>
2011-06-22 21:14:55vstinnerlinkissue9642 messages
2011-06-22 21:14:55vstinnercreate