This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author pitrou
Recipients jnoller, pitrou, sbt
Date 2011-06-13.22:46:09
SpamBayes Score 1.0836792e-06
Marked as misclassified No
Message-id <1308005157.3662.3.camel@localhost.localdomain>
In-reply-to <1307991196.59.0.849860111943.issue12328@psf.upfronthosting.co.za>
Content
Hello,

Thanks for the patch.

>    I would suggest making it a programming error for the overlapped
>    object to be deallocated while the operation is still pending, and
>    to print a RuntimeError if that happens.  (This does not prevent us
>    from still trying to prevent a crash using CancelIoEx().)

Sounds ok to me.

> 6) Not a bug exactly, but poll(timeout) is no longer interruptible
>    with Ctrl-C.  This also means that Queue.get() is no longer
>    interruptible.

There is infrastructure in _multiprocessing to handle Ctrl-C. Look for
"sigint_event" in Modules/_multiprocessing/*. This could be the topic of
a separate issue and patch.

> The unit tests attached pass on Unix.  On Windows versions up to 3.2,
> only test_empty_string fails.  On Windows version 3.3 all three fail.

Could you make the tests part of Lib/test/test_multiprocessing.py?

Also, what is the rationale for the following change:

-            elif timeout == 0.0:
+            elif timeout == 0.0 and nleft != 0:
                 return False
History
Date User Action Args
2011-06-13 22:46:10pitrousetrecipients: + pitrou, jnoller, sbt
2011-06-13 22:46:09pitroulinkissue12328 messages
2011-06-13 22:46:09pitroucreate