Author haypo
Recipients brian.curtin, eric.smith, georg.brandl, haypo, jason.coombs, loewis, nadeem.vawda, ocean-city, santoso.wijaya, tim.golden
Date 2011-06-13.15:18:09
SpamBayes Score 1.69352e-07
Marked as misclassified No
Message-id <1307978290.01.0.368037309096.issue12084@psf.upfronthosting.co.za>
In-reply-to
Content
issue12084_v2.diff doesn't patch os.lstat(bytes): os.lstat(bytes) should call win32_lstat() (which is removed by this patch) instead of stat().

test_os doesn't test os.stat()/os.lstat() with byte filenames. You can for example replace Win32SymlinkTests.check_stat() method by:

    def check_stat(self, link, target):
        self.assertEqual(os.stat(link), os.stat(target))
        self.assertNotEqual(os.lstat(link), os.stat(link))

        bytes_link = os.fsencode(link)
        self.assertEqual(os.stat(bytes_link), os.stat(target))
        self.assertNotEqual(os.lstat(bytes_link), os.stat(bytes_link))
History
Date User Action Args
2011-06-13 15:18:10hayposetrecipients: + haypo, loewis, georg.brandl, jason.coombs, ocean-city, eric.smith, tim.golden, nadeem.vawda, brian.curtin, santoso.wijaya
2011-06-13 15:18:10hayposetmessageid: <1307978290.01.0.368037309096.issue12084@psf.upfronthosting.co.za>
2011-06-13 15:18:09haypolinkissue12084 messages
2011-06-13 15:18:09haypocreate