This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author vstinner
Recipients pitrou, python-dev, vstinner
Date 2011-05-25.21:42:32
SpamBayes Score 0.01756867
Marked as misclassified No
Message-id <1306359752.92.0.00303667123268.issue12175@psf.upfronthosting.co.za>
In-reply-to
Content
> You must Py_DECREF(all) first.
> Also, you should check that "all" is either None or a bytes object.

Right, fixed in bufferedreader_readall-2.patch. By the way, thanks for your reviews.

So, do you think that fileio_readall.patch and bufferedreader_readall-2.patch should be commited, or these changes are useless?
History
Date User Action Args
2011-05-25 21:42:33vstinnersetrecipients: + vstinner, pitrou, python-dev
2011-05-25 21:42:32vstinnersetmessageid: <1306359752.92.0.00303667123268.issue12175@psf.upfronthosting.co.za>
2011-05-25 21:42:32vstinnerlinkissue12175 messages
2011-05-25 21:42:32vstinnercreate