➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author pitrou
Recipients benjamin.peterson, daniel.urban, jcon, pitrou, stutzbach
Date 2011-05-06.15:43:23
SpamBayes Score 0.0024203348
Marked as misclassified No
Message-id <1304696604.76.0.121881969133.issue9971@psf.upfronthosting.co.za>
In-reply-to
Content 
+        if (n <= 0) {
+            if (written > 0 || n == 0)
+                break;
+            if (n == -2) {
+                Py_INCREF(Py_None);
+                res = Py_None;
+            }
+            goto end;
+        }

I think the logic is flawed: if n = -1 and written is > 0, the error will be silenced.
Other than that, the patch looks good to me.
History
Date User Action Args
2011-05-06 15:43:24pitrousetrecipients: + pitrou, benjamin.peterson, stutzbach, daniel.urban, jcon
2011-05-06 15:43:24pitrousetmessageid: <1304696604.76.0.121881969133.issue9971@psf.upfronthosting.co.za>
2011-05-06 15:43:24pitroulinkissue9971 messages
2011-05-06 15:43:23pitroucreate