Message135310
+ if (n <= 0) {
+ if (written > 0 || n == 0)
+ break;
+ if (n == -2) {
+ Py_INCREF(Py_None);
+ res = Py_None;
+ }
+ goto end;
+ }
I think the logic is flawed: if n = -1 and written is > 0, the error will be silenced.
Other than that, the patch looks good to me. |
|
Date |
User |
Action |
Args |
2011-05-06 15:43:24 | pitrou | set | recipients:
+ pitrou, benjamin.peterson, stutzbach, daniel.urban, jcon |
2011-05-06 15:43:24 | pitrou | set | messageid: <1304696604.76.0.121881969133.issue9971@psf.upfronthosting.co.za> |
2011-05-06 15:43:24 | pitrou | link | issue9971 messages |
2011-05-06 15:43:23 | pitrou | create | |
|