Message 134338 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	pitrou
Recipients	amaury.forgeotdarc, asksol, brian.curtin, gregory.p.smith, jnoller, pitrou, santoso.wijaya, tim.golden
Date	2011-04-24.18:38:22
SpamBayes Score	1.5275629e-07
Marked as misclassified	No
Message-id	<1303670303.95.0.613194046107.issue11750@psf.upfronthosting.co.za>
In-reply-to

Content
I agree with Amaury that it would be better in Modules. In my experience, code that is in PC/ is a pain to discover. A couple of nits about the patch: - the functions in the PyMethodDef array could be sorted alphabetically - the defint() macro isn't necessary, PyModule_AddIntMacro() should do the trick - the "_win_handle_object" thing seems misguided, I would vote to remove it, and call CloseHandle() from Python code instead

I agree with Amaury that it would be better in Modules. In my experience, code that is in PC/ is a pain to discover.
A couple of nits about the patch:
- the functions in the PyMethodDef array could be sorted alphabetically
- the defint() macro isn't necessary, PyModule_AddIntMacro() should do the trick
- the "_win_handle_object" thing seems misguided, I would vote to remove it, and call CloseHandle() from Python code instead

History
Date	User	Action	Args
2011-04-24 18:38:24	pitrou	set	recipients: + pitrou, gregory.p.smith, amaury.forgeotdarc, tim.golden, jnoller, brian.curtin, asksol, santoso.wijaya
2011-04-24 18:38:23	pitrou	set	messageid: <1303670303.95.0.613194046107.issue11750@psf.upfronthosting.co.za>
2011-04-24 18:38:23	pitrou	link	issue11750 messages
2011-04-24 18:38:22	pitrou	create