This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author pitrou
Recipients asksol, jnoller, pitrou
Date 2011-04-09.23:07:20
SpamBayes Score 1.0120245e-07
Marked as misclassified No
Message-id <1302390440.77.0.392480963039.issue11814@psf.upfronthosting.co.za>
In-reply-to
Content
There's the following code in pool.py, line 494 and following:

        debug('joining task handler')
        task_handler.join()

        debug('joining result handler')
        task_handler.join()

It seems the last line should read `result_handler.join()` instead.

Additionally, when _terminate() is called, it seems the worker_handler could still run while other threads shut down existing workers, meaning it could start new workers (in _repopulate_pool()) in parallel.

So perhaps the worker_handler should be joined before anything else in _terminate(). It would incur a small latency, though (because of the sleep() call there).
History
Date User Action Args
2011-04-09 23:07:20pitrousetrecipients: + pitrou, jnoller, asksol
2011-04-09 23:07:20pitrousetmessageid: <1302390440.77.0.392480963039.issue11814@psf.upfronthosting.co.za>
2011-04-09 23:07:20pitroulinkissue11814 messages
2011-04-09 23:07:20pitroucreate