This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author rhettinger
Recipients daniel.urban, eric.smith, gruszczy, rhettinger, stutzbach
Date 2011-04-02.22:19:53
SpamBayes Score 0.004244359
Marked as misclassified No
Message-id <1301782794.13.0.656792100315.issue11707@psf.upfronthosting.co.za>
In-reply-to
Content
Nice work.  There are a few nits (dealloc and traverse need to address both python objects in the struct).  I will look at the patch in detail when I get a chance (in the next week or so).

It would be great if more tests were added (in general, C equivalents require more testing than their pure Python counterparts).

If you get a chance, it would be great if we could see some timings to demonstrate that we're getting a significant improvement (that being the primary motivation for the patch).
History
Date User Action Args
2011-04-02 22:19:54rhettingersetrecipients: + rhettinger, eric.smith, stutzbach, gruszczy, daniel.urban
2011-04-02 22:19:54rhettingersetmessageid: <1301782794.13.0.656792100315.issue11707@psf.upfronthosting.co.za>
2011-04-02 22:19:53rhettingerlinkissue11707 messages
2011-04-02 22:19:53rhettingercreate