This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author torsten
Recipients ghaering, pitrou, torsten
Date 2011-03-29.23:02:03
SpamBayes Score 1.7676225e-08
Marked as misclassified No
Message-id <1301439727.49.0.428524071031.issue11688@psf.upfronthosting.co.za>
In-reply-to
Content
> - you need to document the new API in Doc/library/sqlite3.rst

Included in the updated patch.

> +        self.assertTrue([x for x in traced_statements if x.find("create table foo") != -1])
>
> This looks a bit complicated, why not something like
> `any("create table foo" in x for x in traced_statements)`?

Fixed.

> +        sqlite3_trace(self->db, _trace_callback, trace_callback);
> +        if (PyDict_SetItem(self->function_pinboard, trace_callback, Py_None) == -1)
> +            return NULL;
>
> Shouldn't sqlite3_trace() be called only after PyDict_SetItem() succeeds?

Fixed as well. I just reversed the calls. What I dislike about this function pinboard approach is that every function registered as a callback stays pinned to the SQLite connection for the lifetime of the latter. But that belongs into another patch, I guess.
History
Date User Action Args
2011-03-29 23:02:07torstensetrecipients: + torsten, ghaering, pitrou
2011-03-29 23:02:07torstensetmessageid: <1301439727.49.0.428524071031.issue11688@psf.upfronthosting.co.za>
2011-03-29 23:02:04torstenlinkissue11688 messages
2011-03-29 23:02:03torstencreate