This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author torsten.becker
Recipients barry, r.david.murray, terry.reedy, torsten.becker
Date 2011-03-27.17:00:43
SpamBayes Score 3.6315795e-10
Marked as misclassified No
Message-id <1301245244.61.0.634684275498.issue1690608@psf.upfronthosting.co.za>
In-reply-to
Content
> However, there should be a test for that, and I'm curious to know what happens if you use such an address in an address field in the unmodified email package.

I added a test to check if the exceptions get thrown when a address is invalid.

I also added a small test to check how a resulting message should look, it looks good to me but I am not a specialist with email.  Do you have any other ideas how to check if it does not have a negative impact to other parts of the module?


> Instead of directly calling bencode, you should use the charset module and its header_encode method.  Note that you need to turn the charset into a Charset instance first.  The advantage of doing this is that it will choose the "best" encoding to use based on the charset and the contents of the string.

The code also uses email.charset.Charset now.
History
Date User Action Args
2011-03-27 17:00:44torsten.beckersetrecipients: + torsten.becker, barry, terry.reedy, r.david.murray
2011-03-27 17:00:44torsten.beckersetmessageid: <1301245244.61.0.634684275498.issue1690608@psf.upfronthosting.co.za>
2011-03-27 17:00:43torsten.beckerlinkissue1690608 messages
2011-03-27 17:00:43torsten.beckercreate