Message130967
On Tue, Mar 15, 2011 at 7:15 AM, Éric Araujo <report@bugs.python.org> wrote:
>
> Éric Araujo <merwok@netwok.org> added the comment:
>
>> I'm not using "if zlib is not None" since the archive_utils module
>> never explicitly imports zlib.
>
> Well, you can import zlib in that module too to detect in advance whether zipfile will work.
Indeed, but from my POV that's less cleaner than the proposed
solution: importing a module that is not used (other than checking for
a condition) may generate confusion to a reader. IMHO, the proposed
solution may ease the readability of the code block by being
super-explicit about what condition is being handled when creating the
ZipFile.
Let me know if you still consider I should change that. |
|
Date |
User |
Action |
Args |
2011-03-15 12:40:34 | nessita | set | recipients:
+ nessita, tarek, ezio.melotti, eric.araujo, alexis |
2011-03-15 12:40:33 | nessita | link | issue11501 messages |
2011-03-15 12:40:33 | nessita | create | |
|