This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author belopolsky
Recipients belopolsky, georg.brandl, jcea, lemburg, mark.dickinson, ncoghlan, pitrou
Date 2011-02-23.22:00:23
SpamBayes Score 2.543521e-13
Marked as misclassified No
Message-id <1298498424.44.0.0798612824035.issue11286@psf.upfronthosting.co.za>
In-reply-to
Content
I am attaching a new version of issue11286.diff which fixes the issue by removing special handling of n == 0 case from _Unpickler_Read().  Note that _Unpickler_Read() (formerly known as unpickler_read()) only started to return null pointer instead of a pointer to an empty string when given n == 0 after optimizations implemented in issue #9410.  This observation makes me more comfortable with changing the behavior of this function because current behavior is itself a regression from 3.1.

(An off-topic remark:  What was the point of renaming static functions in _pickle.c made in r84653?  There is no need to prefix static C functions with an underscore to make them private and the convention seems to be not to use CamelCase in the names of non-CAPI functions.)
History
Date User Action Args
2011-02-23 22:00:24belopolskysetrecipients: + belopolsky, lemburg, georg.brandl, jcea, mark.dickinson, ncoghlan, pitrou
2011-02-23 22:00:24belopolskysetmessageid: <1298498424.44.0.0798612824035.issue11286@psf.upfronthosting.co.za>
2011-02-23 22:00:23belopolskylinkissue11286 messages
2011-02-23 22:00:23belopolskycreate