This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author neologix
Recipients giampaolo.rodola, neologix, orsenthil, rg3
Date 2011-02-22.07:40:27
SpamBayes Score 4.0689674e-14
Marked as misclassified No
Message-id <AANLkTi=p0bftcqPfF4j9m7FmLkDYMprFmU5z3awEcczj@mail.gmail.com>
In-reply-to <1298327175.69.0.448067040097.issue11199@psf.upfronthosting.co.za>
Content
> rg3 <sarbalap+freshmeat@gmail.com> added the comment:
>
> I have to correct myself. I applied the patch manually to my Python 2.6 installation. In Python 2.6, the line you moved is number 961, and I did the same change.

OK. For information, you can apply it using the Unix "patch" command,
who can most of the time do all the work for you.

>
> With your change, the connection can be closed, but you have to wait for the file to be completely transferred. As I was throttling to 1 KB/sec initially, I thought it was still hanging because it takes more than 1 minute for the test file to be sent. Still, the connection isn't immediately closed when you request to close it.

That's expected, it's a consequence of this point I raised earlier:

> Note that I'm not sure why we need to wait for a further message on the control channel (maybe it's part of an RFC or something...).

The current code explicitely waits for the end of transfer before
closing the data channel.
Don't ask me why, I don't have a clue. I wrote a 2-line patch to
disable this behaviour which seems to work fine, but since I'm not
sure why the code is doing this right now, I'd like some feedback
before doing the change.
History
Date User Action Args
2011-02-22 07:40:28neologixsetrecipients: + neologix, orsenthil, giampaolo.rodola, rg3
2011-02-22 07:40:28neologixlinkissue11199 messages
2011-02-22 07:40:27neologixcreate