This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author valhallasw
Recipients benjamin.peterson, eric.araujo, valhallasw
Date 2011-02-18.22:43:41
SpamBayes Score 5.6214422e-11
Marked as misclassified No
Message-id <1298069024.24.0.224086301061.issue11236@psf.upfronthosting.co.za>
In-reply-to
Content
Sorry, I'm not going to run my patch through the entire test suite, I've got better things to do with my time than setting up a working python-development-test-bench. Especially for a one-line-revert.

The result now is:

valhallasw@dorthonion:~/src/pythonpatch$ python -c "import getpass; print getpass.getpass().__repr__()"
Password: Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "getpass.py", line 71, in unix_getpass
    passwd = _raw_input(prompt, stream, input=input)
  File "getpass.py", line 133, in _raw_input
    line = input.readline()
KeyboardInterrupt


As for a patch - see attachment. It reverts one change from r76000
http://svn.python.org/view/python/trunk/Lib/getpass.py?r1=74860&r2=76000&pathrev=76000 line 65

The ISIG flag is copied from getpass.c (http://www.koders.com/c/fid3C9D79A0C31256E7875CB8930CF8B9E49BDA8C12.aspx line 122). According to the r76000 commit message:

"This change also incorporates some additional getpass implementation
suggestions for security based on an analysis of getpass.c linked to from the issue."
'The issue' should probably be issue7208, but I cannot find any reference to getpass.c there.
History
Date User Action Args
2011-02-18 22:43:44valhallaswsetrecipients: + valhallasw, benjamin.peterson, eric.araujo
2011-02-18 22:43:44valhallaswsetmessageid: <1298069024.24.0.224086301061.issue11236@psf.upfronthosting.co.za>
2011-02-18 22:43:42valhallaswlinkissue11236 messages
2011-02-18 22:43:41valhallaswcreate